Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add @chenrui333 #6399

Merged
merged 1 commit into from
Sep 3, 2019
Merged

README: add @chenrui333 #6399

merged 1 commit into from
Sep 3, 2019

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@chenrui333
Copy link
Member Author

Have contributed many changes in homebrew-core, want to join the homebrew team :)

@Homebrew Homebrew deleted a comment from shortdawg896 Sep 2, 2019
@MikeMcQuaid
Copy link
Member

@chenrui333 Welcome to the team! Please rebase this on origin/master, run brew man, commit the changes and let me know when it's ✅.

@chenrui333
Copy link
Member Author

@MikeMcQuaid Just did:

  • git rebase master
  • brew man
  • forced update

@MikeMcQuaid
Copy link
Member

@chenrui333 You need to also git commit those changes from brew man.

@chenrui333
Copy link
Member Author

I just copied the brew man changes into the repo. Not sure if that works.

@EricFromCanada
Copy link
Member

You need to also pull the latest changes from Homebrew/brew. Try:

cd `brew --repo`
git checkout -- docs/Manpage.md manpages/brew.1 manpages/brew-cask.1
git pull --rebase origin master
brew man

and commit/push those changes.

@chenrui333
Copy link
Member Author

That seems much more clear, thanks @EricFromCanada !

@EricFromCanada
Copy link
Member

I should also point out that the file you need to add your name to is /README.md. The brew man command reads this file to generate the Markdown and manpage files.

@chenrui333
Copy link
Member Author

I see, 🤣 I am adding the README.md change now.

@MikeMcQuaid MikeMcQuaid merged commit 5194870 into Homebrew:master Sep 3, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants