-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: add @chenrui333 #6399
README: add @chenrui333 #6399
Conversation
Have contributed many changes in homebrew-core, want to join the homebrew team :) |
@chenrui333 Welcome to the team! Please rebase this on |
@MikeMcQuaid Just did:
|
@chenrui333 You need to also |
I just copied the |
You need to also pull the latest changes from Homebrew/brew. Try:
and commit/push those changes. |
That seems much more clear, thanks @EricFromCanada ! |
I should also point out that the file you need to add your name to is |
I see, 🤣 I am adding the |
brew style
with your changes locally?brew tests
with your changes locally?